aws-samples / mlops-amazon-sagemaker

Workshop content for applying DevOps practices to Machine Learning workloads using Amazon SageMaker
Apache License 2.0
289 stars 125 forks source link

Pipeline Object Definition doesn't include NotebookStep #36

Open simis2626 opened 7 months ago

simis2626 commented 7 months ago

AWS released Notebook Steps https://aws.amazon.com/about-aws/whats-new/2023/11/api-creating-amazon-sagemaker-notebook-jobs/

but the API object description here: https://aws-sagemaker-mlops.github.io/sagemaker-model-building-pipeline-definition-JSON-schema/#Steps Doesn't include NotebookSteps

This documentation is linked to by the official CloudFormation documentation, and makes it tough to deploy one of these NotebookStep Pipelines via CFN. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sagemaker-pipeline-pipelinedefinition.html#cfn-sagemaker-pipeline-pipelinedefinition-pipelinedefinitionbody

Please update the doco to include the new NotebookStep API Object.

Screenshot 2023-11-30 at 6 28 56 pm
simis2626 commented 7 months ago

Worth noting too that the documentation in this repo is also the canonical reference for the SageMaker API Reference on the Pipeline API Object https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreatePipeline.html#sagemaker-CreatePipeline-request-PipelineDefinition

suyashdb commented 2 weeks ago

@simis2626 how did you get this working without the notebook job step schema?

simis2626 commented 2 weeks ago

@suyashdb unfortunately I didn’t. I was doing this as an experiment to try out the feature but it wasn’t for a mission critical workload. Instead I’ve just parked it until this issue is resolved.