search

aws-solutions / smart-product-solution

The Smart Product Solution is a customer deployable reference architecture to help manufacturers to jumpstart development of innovative connected/smart product services.
Apache License 2.0
28 stars 20 forks source link

README has extra $ in build command #12

Open billkidwell opened 4 years ago

billkidwell commented 4 years ago 
./build-s3-dist.sh $DIST_OUTPUT_BUCKET $SOLUTION_NAME $$VERSION

in the readme should be 

./build-s3-dist.sh $DIST_OUTPUT_BUCKET $SOLUTION_NAME $VERSION```

The extra $ will mess up your template and cause deployment to fail @ CICDHelper.

Error Message:

Error occurred while GetObject. S3 Error Code: NoSuchBucket. S3 Error Message: The specified bucket does not exist (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: b64e1312-1aa6-4795-92f7-fea982534a7e)
gsingh04 commented 4 years ago

Hello,

Thank you for reporting the issue. We have added the issue to our backlog items for now.