aws / amazon-ecs-agent

Amazon Elastic Container Service Agent
http://aws.amazon.com/ecs/
Apache License 2.0
2.08k stars 616 forks source link

Fix EBS TA Windows static check failures #4348

Closed jiuchoe4 closed 2 months ago

jiuchoe4 commented 2 months ago

Summary

Static checks for EBS TA Windows feature branch are failing due to a merge conflict in mount_windows.go and node_windows.go. This PR fixes this. Additionally, removed ecs-agent/csiclient/csi_client_windows_integ_test.go, as this was added during development solely to test staging and unstaging in isolation for Windows environments. We already test this in other tests.

Implementation details

Removed unimplemented holder functions from respective files.

Testing

N/A, these functions have already been tested in previous PRs.

New tests cover the changes: N/A

Description for the changelog

Fix static failures for EBS TA Windows

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.