Removes requirement for Cluster VPC Association to Gateway Service Network to be tagged with "ManagedBy"
Controller no longer manages this association, so the tag should not be expected to be there
Changes the logic of resource naming in Access Log Policy e2e tests such that all AWS resources are created with a partially pseudo-random name
Prevents previously leaked resources from interfering with new test runs due to name conflicts
Changes the logic of Access Log Policy e2e tests to tag all AWS resources with TestSuite=access-log-policy and then to clean up all AWS resources with that tag in the AfterAll block
Subsequent test runs can clean up resources missed in previously interrupted runs
Adds new parameter to TestFramework.NewTestTags function to accept the test suite name
Allows for individual test suites to manage their own resource cleanup without interfering with each other when running in parallel
Makes it clear which test created a specific resource (e.g. in the event of a bug causing leaks)
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A
Testing done on this change:
Ran 13 of 61 Specs in 545.028 seconds
SUCCESS! -- 13 Passed | 0 Failed | 0 Pending | 48 Skipped
--- PASS: TestIntegration (545.03s)
PASS
ok github.com/aws/aws-application-networking-k8s/test/suites/integration 545.761s
Automation added to e2e:
Improved test cleanup.
Will this PR introduce any new dependencies?:
No.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No.
Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
What type of PR is this?
cleanup
Which issue does this PR fix: N/A
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue: N/A
Testing done on this change:
Automation added to e2e:
Improved test cleanup.
Will this PR introduce any new dependencies?:
No.
Will this break upgrades or downgrades. Has updating a running cluster been tested?: No.
Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.