aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
175 stars 50 forks source link

Add e2e test automation workflow #597

Closed solmonk closed 9 months ago

solmonk commented 9 months ago

What type of PR is this?

feature

Which issue does this PR fix:

132

What does this PR do / Why do we need it:

Notes:

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change: Tested in the forked repo

Automation added to e2e: No new test cases added

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

solmonk commented 9 months ago

Still not sure if we should run the test directly over pull request's head. This is something we want ideally, but the e2e test suite requires pretty powerful permission. We can always make the change later though, as it is a simple fix.

solmonk commented 9 months ago

a successful run from my own fork: https://github.com/solmonk/aws-application-networking-k8s/actions/runs/7761811200/job/21171173210

zijun726911 commented 9 months ago

I have first thought about running this on the pull request's context, but seems like it is a security hazard, as the e2e test runner is capable of doing pretty much everything on VPC Lattice + has some other AWS permissions on the internal account.

Seems current workflow has a workflow_dispatch,

Does it currently support to manually trigger a e2e test workflow against the PR's feature branch?

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch