search

aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
175 stars 50 forks source link

Add `DISABLE_TAGGING_SERVICE_API` env to helm chart #655

Closed aaroniscode closed 5 months ago

aaroniscode commented 5 months ago

What type of PR is this? bug

Which issue does this PR fix:

653

What does this PR do / Why do we need it: The DISABLE_TAGGING_SERVICE_API environment variable was not able to be set in the Helm chart

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change: tested manually

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

zijun726911 commented 5 months ago

Thanks for sending this PR, could you help to add few words in the environment.md to explain what the new env variable DISABLE_TAGGING_SERVICE_API used for? thank you so much!

https://github.com/aws/aws-application-networking-k8s/blob/1862bef9b5f4956b08f34b80723464a99682f542/docs/guides/environment.md?plain=1#L90

aaroniscode commented 5 months ago

@zijun726911 added documentation to environment.md