aws / aws-dotnet-deploy

Opinionated tooling that simplifies deployment of .NET applications to AWS.
https://aws.github.io/aws-dotnet-deploy/
Apache License 2.0
140 stars 32 forks source link

chore: remove System.Text.Json dependency to not conflict user apps #872

Closed philasmar closed 1 month ago

philasmar commented 1 month ago

Description of changes: While trying to deploy a web app, the deployment failed due to a conflict between the System.Text.Json in the CDK Templates and the one in my web app. In order to avoid these conflicts, we should remove the reference from the CDK templates.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.39%. Comparing base (bd41f9d) to head (652110d). Report is 3 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #872 +/- ## ======================================= Coverage 62.39% 62.39% ======================================= Files 279 279 Lines 10905 10905 Branches 1515 1515 ======================================= Hits 6804 6804 Misses 3564 3564 Partials 537 537 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.