aws / aws-sdk-go-v2

AWS SDK for the Go programming language.
https://aws.github.io/aws-sdk-go-v2/docs/
Apache License 2.0
2.64k stars 634 forks source link

Lack of VaultState attribute on Describe/List operations for Backup Vault #2738

Closed aristosvo closed 1 month ago

aristosvo commented 2 months ago

Describe the feature

Due to the launch of Logically Air-Gapped Backup Vaults, I tried to implement this resource in Terraform.

However, the VaultState which is given back in https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/backup#CreateLogicallyAirGappedBackupVaultOutput is not available in the other actions of the SDK yet, making it impossible to check for status.

Use Case

Wait until the LAG Backup Vault is available and execute follow up actions

Proposed Solution

Expose VaultStatus in DescribeBackupVault and/or ListBackupVaults

Other Information

No response

Acknowledgements

AWS Go SDK V2 Module Versions Used

1.36.3

Go version used

1.22.6

RanVaknin commented 2 months ago

Hi @aristosvo ,

Thanks for reaching out.

I'm not entirely sure what you mean by "is not available in the SDK yet", since you linked the exact point where it does exist in the SDK.

Based on the rest of the description of the issue, it seems to me that what you are really asking for, is for VaultState to be available in the response of DescribeBackupVault so you can poll for a change in status. Like a waiter, is that correct?

If so, this is not something the SDK team can add. This would have to be a feature request to the backup service team itself because there must be server side support first, for us to be able to add this.

Can you please clarify what you meant here?

Thanks, Ran~

aristosvo commented 2 months ago

Hi @RanVaknin!

Thanks for your reply. I meant indeed the latter, that the Describe or List action doesn't disclose VaultState yet, and indeed something we'd implement in a waiter.

I have checked via the browser, and at least in the List action the VaultState was returned, so it seems the data is there but not published via de API/SDK definition.

RanVaknin commented 2 months ago

Hi @aristosvo ,

Thanks for the clarification.

I have checked via the browser, and at least in the List action the VaultState was returned, so it seems the data is there but not published via de API/SDK definition.

Can you please add some more logs showcasing this? That would make it easier to submit that feature request to that service team on your behalf.

Thanks, Ran~

aristosvo commented 2 months ago

Hi @RanVaknin!

Sure, here they are. Screenshotted from the console network inspection, hope this is good enough?

ListBackupVaults:

Screenshot 2024-08-13 at 04 46 29 Screenshot 2024-08-13 at 04 45 56

DescribeBackupVault:

Screenshot 2024-08-13 at 04 47 25 Screenshot 2024-08-13 at 04 47 01
RanVaknin commented 2 months ago

Hi,

Thank you for the additional info. I was able to get in touch with the backup service team, and have confirmed that this was not properly released. I have asked them to prioritize this in order to unblock you (internal ticket P148107395), but at the moment I don't have an ETA.

I will post updates on this internal inquiry as soon as I have any additional info.

Thanks again, Ran~

aristosvo commented 1 month ago

Hi @RanVaknin!

I will close this issue as the release of 2024-08-30 contains the fields I was waiting for.

Thanks for the support and raising it to the backup service team! 🙏🏽

github-actions[bot] commented 1 month ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

RanVaknin commented 1 month ago

My pleasure, and thank you for your feedback.