aws / aws-sdk-go-v2

AWS SDK for the Go programming language.
https://aws.github.io/aws-sdk-go-v2/docs/
Apache License 2.0
2.68k stars 651 forks source link

add feature tracking for cbor protocol #2821

Closed lucix-aws closed 1 month ago

lucix-aws commented 1 month ago

Add feature metrics tracking for CBOR clients. Not actually used by any service right now, but you can see the codegen results in the cbor protocol test.

lucix-aws commented 1 month ago

We're missing a changelog (should we add automation to check this?)

I left a changelog out because it doesn't actually have any effect on released source. A changelog at the root module here would have just meant a new root module => service module churn because everything has to update to pull it in.

Madrigal commented 1 month ago

Only comment that we'll discuss

I left a changelog out because it doesn't actually have any effect on released source. A changelog at the root module here would have just meant a new root module => service module churn because everything has to update to pull it in.

I don't think our automation can handle a no changelog change IIRC