search

aws / aws-sdk-net

The official AWS SDK for .NET. For more information on the AWS SDK for .NET, see our web site:
http://aws.amazon.com/sdkfornet/
Apache License 2.0
2.05k stars 852 forks source link

V4 Development: DefineConstants requires an overhaul #3326

Open danielmarbach opened 4 months ago

danielmarbach commented 4 months ago

Describe the feature

The constants defined in the project have grown over the years and are a bit messy. There is still BCL constants defined and some of the constants look like they are the standard constants but are actually not. It would be good to do a general sweep over the v4 development branch and get rid of unnecessary constants, BCL definitions and rely as much as possible on the constants already defined by the SDK.

Also some of the defined constants are unnecessarily specific. For example it would be enough with the current target frameworks to use NETSTANDARD, NETCOREAPP and NET and once NETCOREAPP is dropped just NETSTANDARD and NET.

Use Case

Less cognitive overhead for everyone involved

Proposed Solution

No response

Other Information

No response

Acknowledgements

AWS .NET SDK and/or Package version used

All

Targeted .NET Platform

All

Operating System and version

All

normj commented 4 months ago

Agreed they do need to be clean up. These constants started getting used in the SDK during the pre 1.0 of .NET Core and we have never gone back to clean them up to use the standard constants. I'll try and take a look how hard it would be to switch to the standard constants.