Closed jessedoyle closed 3 years ago
Thanks for submitting this! Overall the change looks reasonable, but it looks like our travis based CI test suite has stopped working. We're working on fixing that and should be able to review this week.
I've migrated to GH actions. Can we force a rebuild somehow?
@mullermp - I’ll rebase the upstream changes into the branch. That should trigger a rebuild!
@mullermp - Rebased! Looks like GitHub Actions just needs approval to run.
Thanks for your contribution. We will release this sometime this week.
Hello!
I noticed that building queries dynamically via
#build_query
will mutate the underlying query string passed in to thekey_expr
method when Aws::Record is creating the prepared statement.When using the
frozen_string_literal: true
directive, this causes the following exception to be raised:This PR resolves the issue by modifying the private methods that create a prepared statement to return a new string instance rather than mutate the underlying string.
Issue #, if available:
resolves #115.
Description of changes:
vendor/bundle
and.bundle
to the gitignore file for those of us that vendorize their dependencies._apply_values
and_key_pass
to return a new string instance of a prepared statement after each pass - this way we can avoid calling mutative string methods (i.e.String#gsub!
)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.