search

aws / aws-sdk-ruby-record

Official repository for the aws-record gem, an abstraction for Amazon DynamoDB.
Apache License 2.0
318 stars 41 forks source link

Use client set to migrating model if it exists #78

Closed qsona closed 6 years ago

qsona commented 6 years ago

In table migration, I think we can use client set to the model (if it exists) rather than initializing plain client. What do you think?

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 9c32c3adfffead8eac67012d9f1ec219d8663907 on qsona:migration_client into on aws:master.

awood45 commented 6 years ago

I'm open to this, actually, but I'd want to see unit tests in place before I can take the PR.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling ffb8a6740b2bd3181a0e3cda5c2e55bb15297797 on qsona:migration_client into on aws:master.

qsona commented 6 years ago

@awood45 thank you for quick review. I added specs and amended previous commit. :) Test seems to failed on jruby environment, but I'm not sure it's related to this PR.

qsona commented 6 years ago

@awood45 could you check this?

awood45 commented 6 years ago

Sorry, and thanks for the reminder. Merging now and we'll take a look at pushing a release with this soon.

qsona commented 6 years ago

Thank you! ❤️