Add support for on-demand billing to table migrations.

aws / aws-sdk-ruby-record

Official repository for the aws-record gem, an abstraction for Amazon DynamoDB.

Apache License 2.0

318 stars 41 forks source link

Add support for on-demand billing to table migrations. #94

Closed alboyadjian closed 3 years ago

alboyadjian commented 5 years ago

Accepts :billing_mode option, with values of PAY_PER_REQUEST or PROVISIONED.

If :provisioned_throughput is set, :billing_mode must either not be set or set to PROVISIONED.

If :provisioned_throughput is not set, :billing_mode must be set and must be PAY_PER_REQUEST.

Setting :billing_mode to PAY_PER_REQUEST is invalid if :provisioned_throughput is specified.

Global secondary index througput config is not needed if on-demand billing is set for the table.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 5 years ago

Coverage increased (+0.02%) to 97.456% when pulling 3f126ac45bd01440cc5c795101fa5f6bf4d30a96 on vhl:on-demand-billing-migration into dd89701870030a2407e3c8c7165ab117c00a5e2a on aws:master.

coveralls commented 5 years ago

Coverage increased (+0.02%) to 97.456% when pulling 3f126ac45bd01440cc5c795101fa5f6bf4d30a96 on vhl:on-demand-billing-migration into dd89701870030a2407e3c8c7165ab117c00a5e2a on aws:master.

coveralls commented 5 years ago

Coverage increased (+0.02%) to 97.456% when pulling 3f126ac45bd01440cc5c795101fa5f6bf4d30a96 on vhl:on-demand-billing-migration into dd89701870030a2407e3c8c7165ab117c00a5e2a on aws:master.

brcarp commented 3 years ago

I discovered this issue recently. This pull request has had its second birthday. Are there any plans for it?

brcarp commented 3 years ago

cc/ @alextwoods

alextwoods commented 3 years ago

Thanks for the ping on this! Reviewing now....

alextwoods commented 3 years ago

Looks good - thanks for submitting and apologies it took so long for us to get merged. I'll get a release with a new version out today.

brcarp commented 3 years ago

@alextwoods Thanks for merging this in! What needs to happen for tagging a new version release? Is there anything we can do to support that?

alextwoods commented 3 years ago

Forgot to post here, but this change has been released with aws-record 2.6.0 that went out last week (May 13th).

brcarp commented 3 years ago

Yeah, I didn't see the release tagged here in the repository, although I see that the version was updated in the code.

brcarp commented 3 years ago

Was looking here: https://github.com/aws/aws-sdk-ruby-record/releases

alextwoods commented 3 years ago

Oh - thanks for the callout - usually our release process updates those automatically, but I had some issues with the release scripts. I've manually created/tagged the 2.6.0 release.