search

aws / aws-toolkit-eclipse

(End of life: May 31, 2023) AWS Toolkit for Eclipse
http://aws.amazon.com/eclipse
Apache License 2.0
275 stars 178 forks source link

Update AWS SDK for Java to 1.11.948 to support newer Eclipse runtime of Java 11 #227

Closed eschulma closed 3 years ago

eschulma commented 3 years ago

Newer versions of Eclipse have a mandatory Java 11 runtime, which has broken a number of critical functions in this plugin. Many classes were removed from Java 11 that existed in Java 8. Fortunately, the AWS SDK for Java has already done the hard work of replacing these, which we can take advantage of by updating that dependency. This commit should allow for Java 11 support by this plugin without worrying about exports.

Issue #, if available:

226, #222, #219, and several others. This is relevant for any version of Eclipse that requires JRE 11, such 2020-09 or higher.

Description of changes:

I kept this small, it only updates the AWS Java SDK dependency and fixes the one bit of code in the plugin that needed to change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

eschulma commented 3 years ago

Is the pipeline working? The CodeBuild tests have not run yet -- it has been almost a week.

eschulma commented 3 years ago

You're welcome!

aauronn commented 3 years ago

Is there a published release for this pull request?

MLaunch commented 3 years ago

@hunterwerlla - still experiencing this issue on the latest version of Corretto. Did the fix ever make it into the latest version of Corretto?

eschulma commented 3 years ago

@MLaunch it has nothing to do with Coretto -- there is no new release of this toolkit, and hasn't been for years, unfortunately.

aauronn commented 3 years ago

I was able to get a build working with Java 11, however, when tried to deploy a JAVA 11 project to AWS Lambda the references are missing and if your Lambda Function is not using Java 8 runtime, it does not shows in the available functions combo box. Does this merge fix this issue?

SubZero5z commented 3 years ago

Has this issue been fixed ? I am still facing the same issue even after using the latest version of AWS SDK : 1.12.10 and also using the latest eclipse version: 2021-06 @eschulma

froshyfrosh commented 3 years ago

AFAICS the changes of pull request #227 are still not included if the toolkit is installed the usual way via the Eclipse marketplace. They are included though in the current master branch, so building it as described in the Readme.md file and then installing from the resulting zip archive works.

The plugin I built myself works on recent Eclipse versions (2021-06 / 4.20.0) running on Java 11. With some caveats though: Lambdas always use Java 8 (hard coded - which I changed to Java 11 in my fork and if I find the time I will make it configurable via the GUI), also at least some things probably won't work with federated/STS credentials (e.g. CodeCommit AFAICS but that's a differnt story) and everything is still based on AWS SDK 1.x.