search

aws / efs-utils

Utilities for Amazon Elastic File System (EFS)
MIT License
301 stars 192 forks source link

Add rpm-without-system-rust to rpmspec #237

Closed retornam closed 2 months ago

retornam commented 3 months ago

Updated the rpmspec with the following conditions

[1] is the default and builds the rpmspec with rustc and cargo provided they are installed with yum

[2] builds the rpmspecfile with rustc and cargo installed outside of yum (in cases where rustup was used to install both rustc and cargo)

[1] and [2] makes it possible to build both instances using the Makefile.

The old makefile command

make rpm

stays the same but assumes [1] and the new command

make rpm-without-system-rust

assumes [2]

Issue #, if available: https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1440

Description of changes:

The build in https://github.com/kubernetes-sigs/aws-efs-csi-driver fails because they use an image which installs rust using rustup. Adding make rpm-without-system-rust will allow for such instances when there is the need to build with rust not installed by yum.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mskanth972 commented 3 months ago

/lgtm

retornam commented 3 months ago

@mskanth972 is there anything I can do to help get this merged?

mskanth972 commented 3 months ago

I bought this up internal, we are planning to revert the change which was made in efs-utils previously as its creating a blockage for ADC regions(isolated regions) regarding the rust installation, will update you by end of the week on this.

retornam commented 2 months ago

@mskanth972 hope all is well. Can we get some movement on this PR as it is blocking https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1440

Thanks and have a good weekend