search

aws / eks-anywhere-build-tooling

Build artifacts for upstream dependencies of Amazon EKS Anywhere - https://github.com/aws/eks-anywhere
https://anywhere.eks.amazonaws.com
Apache License 2.0
56 stars 90 forks source link

Update kind manifest image tags during upgrade flow #4064

Closed abhay-krishna closed 1 week ago

abhay-krishna commented 1 week ago

We maintain a list of images that are referenced upstream in Kind's CNI and PV storage manifests and containerd config file. We use this list for find-and-replace operations on certain files on the Kind node image, to replace them with EKS-A kindnetd and local-path-provisioner/local-path-helper images and EKS-D pause image. When bumping Kind versions, the upstream tags may change, which requires us to update the image tags list otherwise the find-and-replace will fail.

This PR adds logic to update this image list whenever we bump the Kind version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

abhay-krishna commented 1 week ago

/cherrypick release-0.21

eks-distro-pr-bot commented 1 week ago

@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4064#issuecomment-2484541056): >/cherrypick release-0.21 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
abhay-krishna commented 1 week ago

/cherrypick release-0.20

eks-distro-pr-bot commented 1 week ago

@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4064#issuecomment-2484541165): >/cherrypick release-0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sp1999 commented 1 week ago

/lgtm

abhay-krishna commented 1 week ago

/approve

eks-distro-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aws/eks-anywhere-build-tooling/blob/main/OWNERS)~~ [abhay-krishna] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
eks-distro-pr-bot commented 1 week ago

@abhay-krishna: new pull request created: #4069

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4064#issuecomment-2484541056): >/cherrypick release-0.21 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eks-distro-pr-bot commented 1 week ago

@abhay-krishna: new pull request created: #4070

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4064#issuecomment-2484541165): >/cherrypick release-0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.