Fix comparisons for string enumerations

aws / fmeval

Foundation Model Evaluations Library

http://aws.github.io/fmeval

Apache License 2.0

151 stars 40 forks source link

Fix comparisons for string enumerations #282

Closed athewsey closed 1 week ago

athewsey commented 1 month ago

Issue #, if available: #186

Description of changes:

Update all string enums to inherit from (str, Enum) so that comparisons work as expected
Add unit tests to cover equality comparisons

Testing done:

Ran ./devtool all and all tests completed successfully

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

athewsey commented 2 weeks ago

Rebased to current main. As I understood from the original review there wasn't actually a need for any change, but let me know if this is not the case!

Appreciate if y'all can help get this merged so we can have a more intuitive API 🙏

keerthanvasist commented 2 weeks ago

Thanks for your submission @athewsey!