fix: mark ec2nodeclass as NotReady when validation is bypassed

rschalo commented 1 week ago

Fixes #N/A

Description When validation is patched off the CRD, we currently overwrite incorrect kubernetes.io/cluster/ tags to isolate nodes created by this cluster from other clusters that may be sharing cluster and karpenter roles. This change takes this enforcement further by marking the affected ec2nodeclass as NotReady.

How was this change tested? local testing

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify[bot] commented 1 week ago

Deploy Preview for karpenter-docs-prod canceled.

Name	Link
Latest commit	09b45e80172b8c2262369ae9b3f1251513ff5a29
Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/673e381d24c2af0008463161

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11940372738

Details

15 of 27 (55.56%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 82.331%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloudprovider/cloudprovider.go	8	13	61.54%
pkg/controllers/nodeclass/status/validation.go	4	11	36.36%
<!--	Total:	15	27	55.56%	-->

Totals
Change from base Build 11924046371:	-0.1%
Covered Lines:	5694
Relevant Lines:	6916

aws / karpenter-provider-aws