search

aws / secrets-store-csi-driver-provider-aws

The AWS provider for the Secrets Store CSI Driver allows you to fetch secrets from AWS Secrets Manager and AWS Systems Manager Parameter Store, and mount them into Kubernetes pods.
Apache License 2.0
459 stars 130 forks source link

Make throttling params QPS and Burst configurable #323

Closed benjaminkz closed 6 months ago

benjaminkz commented 6 months ago

Issue #, if available:

Description of changes:

Kubernetes Go client uses a default value of 5 and 10 for QPS and burst. As a result, our customers may experience client-side rate limiting. This pull request makes them configurable to our customers.

Related issues: https://github.com/aws/secrets-store-csi-driver-provider-aws/issues/136

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.15%. Comparing base (1257240) to head (0aa31b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #323 +/- ## ======================================= Coverage 53.15% 53.15% ======================================= Files 8 8 Lines 730 730 ======================================= Hits 388 388 Misses 332 332 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.