awslabs / aws-c-http

C99 implementation of the HTTP/1.1 and HTTP/2 specifications
Apache License 2.0
137 stars 42 forks source link

improve websocket error reporting #416

Closed graebm closed 1 year ago

graebm commented 1 year ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Base: 79.32% // Head: 79.44% // Increases project coverage by +0.11% :tada:

Coverage data is based on head (cc09b58) compared to base (50201a7). Patch coverage: 91.30% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #416 +/- ## ========================================== + Coverage 79.32% 79.44% +0.11% ========================================== Files 27 27 Lines 11881 11897 +16 ========================================== + Hits 9425 9451 +26 + Misses 2456 2446 -10 ``` | [Impacted Files](https://codecov.io/gh/awslabs/aws-c-http/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/http.c](https://codecov.io/gh/awslabs/aws-c-http/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2h0dHAuYw==) | `53.19% <ø> (ø)` | | | [source/websocket.c](https://codecov.io/gh/awslabs/aws-c-http/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3dlYnNvY2tldC5j) | `81.99% <ø> (ø)` | | | [source/websocket\_encoder.c](https://codecov.io/gh/awslabs/aws-c-http/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3dlYnNvY2tldF9lbmNvZGVyLmM=) | `94.23% <80.00%> (-0.98%)` | :arrow_down: | | [source/websocket\_decoder.c](https://codecov.io/gh/awslabs/aws-c-http/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3dlYnNvY2tldF9kZWNvZGVyLmM=) | `100.00% <100.00%> (+1.58%)` | :arrow_up: | | [source/h2\_connection.c](https://codecov.io/gh/awslabs/aws-c-http/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2gyX2Nvbm5lY3Rpb24uYw==) | `83.75% <0.00%> (+0.76%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.