search

awslabs / aws-c-http

C99 implementation of the HTTP/1.1 and HTTP/2 specifications
Apache License 2.0
136 stars 42 forks source link

Support request override for connection monitor #455

Closed TingDaoK closed 1 year ago

TingDaoK commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e099d43) 79.48% compared to head (38c62f4) 79.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #455 +/- ## ========================================== - Coverage 79.48% 79.30% -0.19% ========================================== Files 27 27 Lines 11511 11534 +23 ========================================== - Hits 9150 9147 -3 - Misses 2361 2387 +26 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-http/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/connection.c](https://app.codecov.io/gh/awslabs/aws-c-http/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2Nvbm5lY3Rpb24uYw==) | `79.75% <100.00%> (+0.20%)` | :arrow_up: | | [source/h1\_stream.c](https://app.codecov.io/gh/awslabs/aws-c-http/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2gxX3N0cmVhbS5j) | `82.32% <100.00%> (+0.07%)` | :arrow_up: | | [source/connection\_monitor.c](https://app.codecov.io/gh/awslabs/aws-c-http/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2Nvbm5lY3Rpb25fbW9uaXRvci5j) | `97.11% <94.11%> (-1.86%)` | :arrow_down: | | [source/h1\_connection.c](https://app.codecov.io/gh/awslabs/aws-c-http/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2gxX2Nvbm5lY3Rpb24uYw==) | `89.98% <7.14%> (-1.56%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-http/pull/455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TingDaoK commented 1 year ago

prefer to https://github.com/awslabs/aws-c-http/pull/456