awslabs / aws-c-http

C99 implementation of the HTTP/1.1 and HTTP/2 specifications
Apache License 2.0
136 stars 42 forks source link

Fix the websocket shutdown behavior #483

Closed TingDaoK closed 3 months ago

TingDaoK commented 3 months ago

The bug was introduced in PR #474

Let's take a whole new approach these channel-shutdown-window-deadlock issues:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (7db2452) to head (791c582).

Files Patch % Lines
source/websocket.c 90.90% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #483 +/- ## ========================================== + Coverage 79.55% 79.61% +0.06% ========================================== Files 27 27 Lines 11688 11683 -5 ========================================== + Hits 9298 9302 +4 + Misses 2390 2381 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.