awslabs / aws-deployment-framework

The AWS Deployment Framework (ADF) is an extensive and flexible framework to manage and deploy resources across multiple AWS accounts and regions based on AWS Organizations.
Apache License 2.0
668 stars 226 forks source link

Add AccessControl on S3 Buckets #681

Closed sbkok closed 10 months ago

sbkok commented 10 months ago

Why?

At the moment, if there is an AccessControl set on the S3 Bucket (in v3.2.0 ADF had this set), you cannot remove it and move to the new Bucket Ownership Rules.

The only option to move to the new Bucket Ownership Rules would be to add those and remove the AccessControl property after. However, since we need to allow customers to upgrade, we cannot do this in a single release.

What?

Added the Bucket Ownership Rules today, and keep the AccessControl for now.

We can remove the AccessControl property in a future version. While we instruct customers to first upgrade to v4.0.0 if they need to move to the version where this property is removed.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.