[Feat]: Add Python isort and black linters.

awslabs / aws-deployment-framework

The AWS Deployment Framework (ADF) is an extensive and flexible framework to manage and deploy resources across multiple AWS accounts and regions based on AWS Organizations.

Apache License 2.0

668 stars 226 forks source link

[Feat]: Add Python isort and black linters. #684

Open javydekoning opened 10 months ago

javydekoning commented 10 months ago

Describe the feature

To ensure code consistency we want to add 2 linters.

Use Case

Adding these linters will ease code reviews going forward.

Proposed Solution

[ ] Enable linter in one commit
[ ] Add syntax changes in the second
[ ] Open PR

Acknowledgements

[X] I may be able to implement this feature request

alexevansigg commented 9 months ago

Hey Javy.. we might consider looking into ruff linter https://docs.astral.sh/ruff/

it can do i-sort linting and black formatting .. but much faster... also can replace pylint, flake8, pep8 etc if you want to follow any rules/styles from those.

javydekoning commented 7 months ago

I'll look into this. Seems it is included in MegaLinter: https://megalinter.io/latest/descriptors/python_ruff/