awslabs / aws-deployment-framework

The AWS Deployment Framework (ADF) is an extensive and flexible framework to manage and deploy resources across multiple AWS accounts and regions based on AWS Organizations.
Apache License 2.0
668 stars 226 forks source link

Fix missing deployment_account_id and initial deployment global IAM bootstrap #686

Closed sbkok closed 8 months ago

sbkok commented 10 months ago

Why?

Issues: #659 and #594.

When installing ADF the first time, the global IAM bootstrap stack that gets deployed is sourced from the adf-bootstrap/global-iam.yml.

The reason for this behaviour is the absence of the global-iam.yml file in the deployment OU bootstrap folder (adf-bootstrap/deployment/global-iam.yml).

It iterates to the parent directory until it finds a global-iam.yml to deploy. Hence, when the adf-bootstrap/global-iam.yml gets deployed in the deployment account, it was looking for the deployment_account_id SSM parameter. That did not get deployed in the deployment account.

What?


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sbkok commented 8 months ago

I moved this change to a larger PR with related changes to ADF's use of SSM Parameter Store. Closing this one, as #695 supersedes it.