search

awslabs / aws-js-s3-explorer

AWS JavaScript S3 Explorer is a JavaScript application that uses AWS's JavaScript SDK and S3 APIs to make the contents of an S3 bucket easy to browse via a web browser.
Apache License 2.0
827 stars 278 forks source link

Let us cancel uploads properly #74

Closed danil-smirnov closed 4 years ago

danil-smirnov commented 4 years ago

Description of changes:

I have discovered that Cancel button in Upload dialog doesn't do anything except the dialog hiding. However, upload continues after that and files appear in the bucket corrupted.

With this pull request we will cancel uploads properly issuing abort() call for every managed upload created. No corrupted files will appear, while completed ones are kept intact.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

john-aws commented 4 years ago

Hi Danil, thanks for this change. I will review shortly.

danil-smirnov commented 4 years ago

Hi @john-aws

Just to let you have more motivation to consider this change, I'm posting a video how it looks like when you started uploading large file, then cancel, and then start the same file again ;)

https://i.gyazo.com/7a3321017fc3f5fbfd3b087c52b0cf78.mp4

john-aws commented 4 years ago

Appreciate this change Danil. I might want to make a couple of minor changes at some point, if that's OK. For example, if you're uploading 3 small files and 3 large files and you cancel the upload, in all likelihood the small files uploaded successfully and the large files were cancelled. The current behavior quickly closes the upload modal so the user cannot see which files were uploaded, and which were not. Might be good to show individual status (complete or cancelled) for each file, then let the user close the modal. Anyhow, minor changes.

danil-smirnov commented 4 years ago

Might be good to show individual status (complete or cancelled) for each file, then let the user close the modal.

Great idea, John! I like your approach much more than the current one