search

awslabs / aws-js-s3-explorer

AWS JavaScript S3 Explorer is a JavaScript application that uses AWS's JavaScript SDK and S3 APIs to make the contents of an S3 bucket easy to browse via a web browser.
Apache License 2.0
825 stars 276 forks source link

[v2-alpha] Files list stays obsolete after upload cancelled #87

Closed danil-smirnov closed 4 years ago

danil-smirnov commented 4 years ago

Hi @john-aws

I've integrated the latest commit into my setup and discovered a minor issue: after upload is partially done (some files are done, some cancelled) there no refresh of files list happens.

john-aws commented 4 years ago

Will take a look. Thanks for reporting this.

john-aws commented 4 years ago

Hi @danil-smirnov, I was unable to repro this. I uploaded 6 files of varying sizes. The smaller files completed (the progress indicator showed 100% and went green), then I hit Cancel. This cancelled the incomplete uploads, and then refreshed the underlying list of files so that it now included the small files that had been successfully uploaded. I tested this twice with the same results.

Can you provide repro instructions? Thanks.

danil-smirnov commented 4 years ago

@john-aws It's easily reproducible:

Empty folder:

Screenshot 2020-05-18 at 18 11 08

Added files:

Screenshot 2020-05-18 at 18 11 26

Canceled upload:

Screenshot 2020-05-18 at 18 11 38

Empty folder still (no autorefresh):

Screenshot 2020-05-18 at 18 11 49

Files appeared after manual refresh:

Screenshot 2020-05-18 at 18 11 59
danil-smirnov commented 4 years ago

@john-aws Could it be the issue manifests itself when the last file cancelled only?

john-aws commented 4 years ago

Fixed by https://github.com/awslabs/aws-js-s3-explorer/commit/e6fc63e4f4d11370f89fae927848911fca2e3f68.

danil-smirnov commented 4 years ago

Great @john-aws , confirming the fix, thanks!