search

awslabs / aws-lambda-redshift-loader

Amazon Redshift Database Loader implemented in AWS Lambda
Other
597 stars 164 forks source link

Missing callback in createS3EventSource when notification configuration already exists #211

Open taoweng100 opened 4 years ago

taoweng100 commented 4 years ago

common.js/createS3EventSource method: There is a missing callback in case of notification configuration already exists.

At line 574 of common.js Could you please change the code from:

if (!configAlreadyExists){ logger.info('Creating notification configuration');

to:

if (configAlreadyExists) { callback(); } else { logger.info('Creating notification configuration');