search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.19k stars 773 forks source link

Delegation #145

Closed joguSD closed 8 years ago

joguSD commented 8 years ago

Implemented Wizard Delegation. Wizard specifications can now specify a Retrieval step to delegate like so:

"Retrieval": {
    "Type": "Wizard",
    "Resource": "SubWizardName",
    "Path": "JMESPath.query"
}

A stage's resolution is no longer a void operation, and the data that would be stored in the environment is now also returned at the end of the stage. Upon executing the final stage the return value from it is returned as the final result of executing the wizard.

This PR also has a couple fixes to old unit tests to increase coverage.

joguSD commented 8 years ago

Unit tests are currently failing after an upstream change on the cli. The root cause is that pytest will capture IO by default and stubs input so that it will throw exceptions if it's attempted to be read. I've opened an upstream pull request on pytest to add the missing attribute to their stub. https://github.com/pytest-dev/pytest/pull/1866

kyleknap commented 8 years ago

Looks good. Just had a question on the interface.

kyleknap commented 8 years ago

Cool. Interface looks much better. :ship: