search

awslabs / deequ

Deequ is a library built on top of Apache Spark for defining "unit tests for data", which measure data quality in large datasets.
Apache License 2.0
3.18k stars 519 forks source link

Anomaly Detection: Add Daily Season with Hourly Interval to HoltWinter #546

Closed zeotuan closed 4 months ago

zeotuan commented 4 months ago

Add Daily Season with Hourly Interval to HoltWinter: #296 Add constructor that directly take seriesPeriodicity

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

zeotuan commented 4 months ago

rdsharma26 Hi Can you help review this PR? It would be great if HoltWinter support more seasonality and interval. Also having a custom seriesPeriodicity would allow others to construct their own seasonality without always having to make changes to source code

rdsharma26 commented 4 months ago

@zeotuan Thanks for the PR! The change looks good. However, would it be possible to add a unit test that shows how a custom value for seriesPeriodicity can be used?

zeotuan commented 4 months ago

@rdsharma26 Thanks. Tests Added for Custom seriesPeriodicity and Hourly Interval/Daily Seasonality

zeotuan commented 4 months ago

I have addressed the comments.

rdsharma26 commented 4 months ago

Thanks for addressing the comments. LGTM.