search

awslabs / dgl-ke

High performance, easy-to-use, and scalable package for learning large-scale knowledge graph embeddings.
https://dglke.dgl.ai/doc/
Apache License 2.0
1.28k stars 196 forks source link

The Bin Path Issue in dist_train.py line 79 #117

Closed Zarca closed 4 years ago

Zarca commented 4 years ago

Hi, I noticed that when use the distribution train, when launch the kvstore server and client, it seems that the bin path is fixed to within "/usr/local/bin:/bin:/usr/bin:/sbin/" in dglke/dist_train.py like below: https://github.com/awslabs/dgl-ke/blob/ad4be69b99240f5eede28700bdb6db109973140f/python/dglke/dist_train.py#L79

however, if the user's develop environment is conda, is may cause some problem. For me ,I use conda as my python environment, so the two executable files named dglke_server and dglke_clinet is automatically loacated in "/root/miniconda3/bin/" directory , so it will cause this two files can't be launch correctly.

I suggest that ,maybe when it comes to the path setting, it should add some code to find the right path of dglke's running executable files like dglke_server etc.

Is that right?

classicsong commented 4 years ago

Currently DGL-ke does not provide conda install. We will provide it latter. Sorry for the inconvenience.

classicsong commented 4 years ago

You need to add it into your PATH environment manually.