search

awslabs / mls-rs

An implementation of Messaging Layer Security (RFC 9420)
Apache License 2.0
105 stars 19 forks source link

[uniffi] Expose `RosterUpdate` on `Commit` #127

Closed mgeisler closed 8 months ago

mgeisler commented 8 months ago

Issues:

Addresses #81.

Description of changes:

More infrastructure to let us talk about roster updates on a group.

Call-outs:

The deep clones are potentially worry-some here. The clone in signing_identity is also annoying. I don't know if it'll be a problem yet, but because we cannot return borrowed data across the FFI boundary, this is probably the best we can do right now.

Testing:

New integration test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

mgeisler commented 8 months ago

See https://github.com/mozilla/uniffi-rs/issues/2043 for the problem of exposing PartialEq and friends via UniFFI — I don't think it's possible right now, but I would love to be proven wrong :smile:

mgeisler commented 8 months ago

See mozilla/uniffi-rs#2043 for the problem of exposing PartialEq and friends via UniFFI — I don't think it's possible right now, but I would love to be proven wrong 😄

This is fixed, thank to the help of @mhammond in the linked issue! :tada:

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.53%. Comparing base (98cf9fe) to head (6e1b331).

Files Patch % Lines
mls-rs-uniffi/src/lib.rs 94.44% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #127 +/- ## ========================================== + Coverage 89.52% 89.53% +0.01% ========================================== Files 173 173 Lines 31404 31438 +34 ========================================== + Hits 28114 28149 +35 + Misses 3290 3289 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.