search

awslabs / mountpoint-s3-csi-driver

Built on Mountpoint for Amazon S3, the Mountpoint CSI driver presents an Amazon S3 bucket as a storage volume accessible by containers in your Kubernetes cluster.
Apache License 2.0
215 stars 26 forks source link

Add sample Dockerfile for building Mountpoint from source #296

Closed unexge closed 2 weeks ago

unexge commented 2 weeks ago

Sometimes it's useful to be able to build Mountpoint from source to test work-in-progress features. This PR adds a sample Dockerfile to achieve that. One can build the CSI Driver image by compiling Mountpoint from source by:

$ DOCKERFILE="Dockerfile.source" REGISTRY=ACCOUNT_ID.dkr.ecr.eu-north-1.amazonaws.com TAG=latest IMAGE_NAME=mountpoint-csi-driver-testing OUTPUT_TYPE=docker make image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

muddyfish commented 2 weeks ago

This doesn't build MP from source exactly - instead from a published commit. Could we rename this to something else? Say Dockerfile.github?

unexge commented 2 weeks ago

For me, I'd still consider this as building from source as opposed to using prebuilt artifacts. Mountpoint has also a Dockerfile.source, and it also builds Mountpoint by cloning the repository.

muddyfish commented 2 weeks ago

I'm fine approving this, but I'm unsure what we'd call a build from local sources. Perhaps Dockerfile.local

unexge commented 2 weeks ago

That sounds good to me, changed to Dockerfile.local.