search

awslabs / oci-add-hooks

Add oci hooks to Docker
Apache License 2.0
60 stars 15 forks source link

Repo versioning not compatible with some orgs. Can we tag the repo with explicit versions? #12

Closed scottblack1 closed 1 year ago

scottblack1 commented 1 year ago

Hi folks,

Some brief background; I am working on a k8s 1.25 upgrade for EKS. This is the first cut of EKS AMIs where the non-gpu version of the AMI does not come with oci-add-hooks installed by default. I am assuming this is because of the move to containerd.

I notice the GPU 1.25 AMIs do have this however I have a requirement to build my own AMI using the non-GPU base.

This leads me to the issue - my company has a strict procurement / approval process for external components. As part of that, they will approve a specific version (e.g. v1.0.0). Each new version needs reviewed again before approval. This repo has no versioning strategy hence I am unable to use this component (which I need). I.e. the process will not approve (master) as it needs an independent version.

The ask: Can we please tag this repos current master with e.g. v1.0.0? Do we have any objection to creating tags / release version on this repo?

Thanks,

Scott

scottblack1 commented 1 year ago

I have noted that the version of oci-add-hooks used in the EKS 1.25 GPU image is off the commit id: 325a34004f3919480f2f3b2bd42725a07ae5f8c0

It would be excellent if someone with permission could run something similar to:

git tag -a 1.0.0 325a34004f3919480f2f3b2bd42725a07ae5f8c0

scottblack1 commented 1 year ago

From my side, I have received an exception here so I will close.