awslabs / route53-dynamic-dns-with-lambda

A Dynamic DNS system built with API Gateway, Lambda & Route 53.
Apache License 2.0
486 stars 167 forks source link

Quick setup using Terraform #8

Closed JoyceBabu closed 6 years ago

JoyceBabu commented 7 years ago

Added support for setting up the configuration using terraform.

seangreathouse commented 7 years ago

Hey Joyce, Thanks for the contribution! I had a CloudFormation template on my todo list. I need to test it before I can merge. "The terraform based setup is currently in beta stage, and has not been properly tested." Can you elaborate? Ideally you have submitted a working solution....

Best, Sean

JoyceBabu commented 7 years ago

This is my first experience with terrraform. I have tested it a few times, and it worked without any issues. It will fail, rather than overwrite, if there is an existing resource with the same name. So it should be safe to use.

Since this is the initial implementation, I thought it would be safe to add that warning.

I wanted it to add the NS record too, in case of sub domain. But decided not to do it, since that would require modifying an existing resource.

seangreathouse commented 6 years ago

Version 2 launched with CloudFormation support