awslabs / service-workbench-on-aws

A platform that provides researchers with one-click access to collaborative workspace environments operating across teams, universities, and datasets while enabling university IT stakeholders to manage, monitor, and control spending, apply security best practices, and comply with corporate governance.
Apache License 2.0
177 stars 119 forks source link

[Bug] Deploy using EC2 instance - nodejs 14 deploys but no CloudFormation stacks #1234

Closed dcloud9 closed 1 year ago

dcloud9 commented 1 year ago

Describe the bug Our use cases are as follows:

  1. EC2 AMI: amzn2-ami-kernel-5.10-hvm-*-x86_64-gp2
  2. Upgrade SWB from v5.2.10 to v6.1.0
  3. Fresh install/deploy SWB v6.1.0

Both cases deployed successfully using the steps as per SWB implementation guide, but not with documented tools version. The tools version combination that deploys successfully and failed are as follows:

Tools OK Failed OK2
golang v1.17.2 v1.17.2 v1.17.2
nvm-sh v0.35.3 v0.35.3 v0.35.3
nodejs v12.22.12 14.x, 16.x, 18.x 14.x, 16.x
pnpm v5.4.2 6.x, 7.x , 8.x v5.x (latest)
serverless v3.35.2 v3.35.2 v3.35.2
hygen 6.2.11 6.2.11 6.2.11

To Reproduce Steps to reproduce the behavior:

  1. Launch EC2 with supported/documented AMI as above.
  2. Follow the Tools table above with the column OK version (successful with Cloudformation stacks)
  3. Terminate the EC2 instance.
  4. Launch EC2 with supported/documented AMI as above.
  5. Follow the Tools table above with the column FAILED versions (successful but without CloudFormation stacks)
  6. Terminate the EC2 instance.
  7. Repeat 4 until all FAILED versions completed.

Expected behavior

  1. We expect the ones with FAILED versions to be successful and with CloudFormation stacks
  2. It'll be helpful if there's a matrix of versions tested somewhere in the README or Implementation Guide.

Screenshots

Versions (please complete the following information):

Additional context Reference matrix for nodejs and pnpm versions here

rangfeli commented 1 year ago

Hi @dcloud9, for Service Workbench, pnpm v5 is supported, however newer versions of pnpm greater than v5 are not supported and result in the improper Success message. We recommend using the latest version of pnpm v5 for a successful deployment.

As well, regarding the Node version, Node 16 and 14 are supported for Service Workbench.

The versions of the other tools mentioned should work as expected.

dcloud9 commented 1 year ago

Hi @dcloud9, for Service Workbench, pnpm v5 is supported, however newer versions of pnpm greater than v5 are not supported and result in the improper Success message. We recommend using the latest version of pnpm v5 for a successful deployment.

As well, regarding the Node version, Node 16 and 14 are supported for Service Workbench.

The versions of the other tools mentioned should work as expected.

Updated the table with OK2 column, tested both on install and upgrade use cases. Tools OK Failed OK2
golang v1.17.2 v1.17.2 v1.17.2
nvm-sh v0.35.3 v0.35.3 v0.35.3
nodejs v12.22.12 14.x, 16.x, 18.x 14.x, 16.x
pnpm v5.4.2 6.x, 7.x , 8.x v5.x (latest)
serverless v3.35.2 v3.35.2 v3.35.2
hygen 6.2.11 6.2.11 6.2.11
rangfeli commented 1 year ago

Thank you for making us aware of this and we're glad to see you are having successful deployments for Service Workbench using the supported versions of the tools.

If you face any other issues regarding your deployments, be sure to let us know!