Import Feature needs popup notification

axc450 / pbs

Battle Pet Combat Scripting

MIT License

30 stars 11 forks source link

Import Feature needs popup notification #110

Open nbartley opened 2 weeks ago

nbartley commented 2 weeks ago

Small issue with the new xufu script blocks.

You have an old script block in an import. It errors on import (bad action for instance) The error appears on screen. The user has NO CLUE the plugin is now doing this conversion from xufu blocks to scripts automagically and the error could be for anything....

Script needs a popup or something indicating this is happening, and it shouldn't be auto importing scripts from old copy pasta, only new stuff. Processing old stuff should be a option/button/something.

bloerwald commented 2 weeks ago

It was intentionally done automatically since the feature was added with "I'll add the other side in a week" in mind.
The issue for bad & in exports from XuFu has been worked around in the latest versions.
Is there a relevant amount of scripts that are still invalid? What errors do you get?
I would really like to keep the automatic import, but am fine with a "mark this script as failed and don't try again until it changes".
People don't even know the scripts addon has a GUI. Adding it as a manual action in it would be the same as just not having the feature, sadly.

nbartley commented 2 weeks ago

1) Cool. Makes sense. 2) Excellent, that was the primary area where my fails were. 3) No, 2 was the primary problem. 4) I agree the automatic import is great, but I see two issues... a) where a user has modified the script with their own, what is it doing then? b) will it always auto-import.... it should only be doing that once (IE it should have failed and never checked again rather than notifying every startup) 5) Hahaha, I don't think I've ever gone into the real gui either.

bloerwald commented 2 weeks ago

4a: If a user has manually added the script but it is still in the notes:

If the script is identical (ignoring whitespace), the script is removed from the note.
If the script is different, the user is notified, like on the errors you had. It tells them to remove one side.

4b: It will currently always auto-import a few seconds after login (if out of combat). Yes, this means it will prompt users to remove one side in that case on every login. Yes, that might be annoying, but honestly, I doubt that really happens more than maybe once. The feature was on site for a week before the addon automatically handles them. What's the chance of someone exporting a team, not exporting the script and manually adding a different script, or modifying it?

5: Yeah, you see, that's why it is automagic, and we added this hack rather than telling people to use the (existing) team+script export in the scripts addon.