Closed milapsheth closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.14%. Comparing base (
aa421a9
) to head (a006f21
).:exclamation: Current head a006f21 differs from pull request most recent head 8d5160a. Consider uploading reports for the commit 8d5160a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think one could pass rotate signers into approve messages and vice versa, which is potentially dangerous.
Discussed offline, but adding here for completeness. The data hash being signed also depends on CommandType
which isn't user controlled and avoids this issue.
AXE-3660
Breaking events
ContractCallApproved
now includes themessageId
instead of tx hash and event index separatelySignersRotated
event is used instead ofOperatorshipTransferred
to adhere to the updated naming conventioncommandId
derivation has changed. SeemessageToCommandId
here. It's still guaranteed to be globally unique.