axelarnetwork / axelar-gmp-sdk-solidity

Solidity libraries and utilities provided by Axelar.
27 stars 30 forks source link

feat(amplifier)!: amplifier gateway v2 #154

Closed milapsheth closed 5 months ago

milapsheth commented 5 months ago

AXE-3660

Breaking events

commandId derivation has changed. See messageToCommandId here. It's still guaranteed to be globally unique.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.14%. Comparing base (aa421a9) to head (a006f21).

:exclamation: Current head a006f21 differs from pull request most recent head 8d5160a. Consider uploading reports for the commit 8d5160a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #154 +/- ## ========================================== + Coverage 96.80% 98.14% +1.33% ========================================== Files 47 47 Lines 752 755 +3 Branches 158 156 -2 ========================================== + Hits 728 741 +13 + Misses 4 1 -3 + Partials 20 13 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

milapsheth commented 5 months ago

I think one could pass rotate signers into approve messages and vice versa, which is potentially dangerous.

Discussed offline, but adding here for completeness. The data hash being signed also depends on CommandType which isn't user controlled and avoids this issue.