axelarnetwork / axelar-gmp-sdk-solidity

Solidity libraries and utilities provided by Axelar.
27 stars 30 forks source link

fix(governance): add check for strict Multisig threshold validation #177

Closed blockchainguyy closed 2 months ago

blockchainguyy commented 3 months ago

Strict Weighted Multisig threshold validation

This PR adds a check to revert if there are any leftover signatures, when threshold is crossed to make the threshold validation strict.

Jira Ticket

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.69%. Comparing base (ddff2f9) to head (082794d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #177 +/- ## ======================================= Coverage 98.68% 98.69% ======================================= Files 48 48 Lines 763 764 +1 Branches 160 160 ======================================= + Hits 753 754 +1 Misses 1 1 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

milapsheth commented 3 months ago

Rename PR to fix(governance): .. since it's a non breaking fix in the governance contract folder