axelarnetwork / axelarjs

Axelar Network foundations for Javascript/Typescript application development
Apache License 2.0
10 stars 8 forks source link

fix: search interchain tokens query searching only first chain #454

Closed SGiaccobasso closed 2 months ago

SGiaccobasso commented 2 months ago

Description

๐ŸŽซ Issue:

โ›‘๏ธ What was done:

Fixed an issue where searching a token without specifying chain id was failing. The issue was that the query was returning undefined and not null as expected by the code, returning only the result of the first chain searched. When the chain was specified, the query was looking for the specified chain first, that's what made it work.

Type of change

Please delete options that are not relevant.

๐Ÿงช How to test:

Run the app and go to http://localhost:3000/api/interchain-token/search?tokenAddress=0x0c66d591d1ff5944A44aebB65c33f6B6e82a124F The same query without the change should fail.

๐Ÿ—’๏ธ Notes:

๐ŸŽฅ Recording:

https://github.com/user-attachments/assets/c6a91790-ffee-4523-85a8-714581aa27a3

Closes #453

changeset-bot[bot] commented 2 months ago

๐Ÿฆ‹ Changeset detected

Latest commit: 92c813add0a15c8c5d615e921a5f9d980f9e9bee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @axelarjs/maestro | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
axelar-maestro โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 20, 2024 1:15am
axelar-registry โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 20, 2024 1:15am
axelar-ui โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 20, 2024 1:15am