axelarnetwork / tofn

A threshold cryptography library in Rust
Apache License 2.0
112 stars 23 forks source link

FillVecMap::set should throw an error if value is already set #112

Closed milapsheth closed 3 years ago

milapsheth commented 3 years ago

When multiple messages are received from the same party, only the last one is kept. But for honest parties, there should be only one message from each party per round. If we receive multiple messages, we should flag that party as a faulter. Furthermore, we should remove the implicit overwrite in the FillVecMap.set method, so that it returns an error instead.

ggutoski commented 3 years ago

I think we now already do this.

milapsheth commented 3 years ago

Ah, cool. I'll take a look and address the other part of this issue then.