search

axelerant / engg-handbook

Axelerant Engineering Handbook
https://engg-handbook.axelerant.com/
3 stars 11 forks source link

ADR list - sorting and filtering #196

Closed PGaigole closed 4 months ago

PGaigole commented 4 months ago
netlify[bot] commented 4 months ago

Deploy Preview for axelerant-engg-handbook ready!

Name Link
Latest commit 19350874f9a2ba1b02cd546469d14d3175b4af5b
Latest deploy log https://app.netlify.com/sites/axelerant-engg-handbook/deploys/6690dd3ce6a40800081d64fa
Deploy Preview https://deploy-preview-196--axelerant-engg-handbook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

swarad07 commented 4 months ago

All well on the CSS front now. Will let Zeshan review the functional part and merge

PGaigole commented 4 months ago

@PGaigole Thanks for all the work. Please see some observations:

  • Clicking the category buttons opens the filter dropdown.
  • The filter should work within the current tab. So if I am under the Drupal category, it should filter from that category only. Currently, it switches to All when we filter the results.

If adding a loader seems complicated, we can leave it for now and worry about it later when it actually matters.

I will take a look at these observations and work on them. Currently, I added a loader, I think if choose a slower connection, you might be able to see the same.

hussainweb commented 4 months ago

This is good work but few things can be made better. Let's do those in a follow-up.