Compilation error when using VS2022 v17.8.0

[rh101]

• axmol version:
• devices test on:
• developing environments
  • NDK version: r23c
  • Xcode version: 14.2
  • Visual Studio:
    • VS version: 2022 (17.8.0)
    • MSVC version: 1929, 1934, 19.35, 19.36, 19.37
    • Windows SDK version: 10.0.22621.0
  • cmake version: Steps to Reproduce:

It seems that _String_iter_types has been updated to remove redundant template parameters: https://github.com/microsoft/STL/commit/45111bbc67c58fd3a5d7e172f8eb29c80c750ff6#diff-47339b57101941628ad9f2c5369af8928f218a6716d304e14b7480dcc84392f6

It seems to work if the code in ntcvt.hpp is changed from this:

namespace detail
{
// different with resize, not all of fill new memory with '\0'
template <class _Elem, class _Traits = std::char_traits<_Elem>,
          class _Alloc = std::allocator<_Elem>>
class intrusive_string : public std::basic_string<_Elem, _Traits, _Alloc>
{
public:
#if _MSC_VER >= 1920 // VS2019+
  using _Alty        = std::_Rebind_alloc_t<_Alloc, _Elem>;
  using _Alty_traits = std::allocator_traits<_Alty>;

  using _Scary_val = std::_String_val<
      std::conditional_t<std::_Is_simple_alloc_v<_Alty>, std::_Simple_types<_Elem>,
                         std::_String_iter_types<
                             _Elem, typename _Alty_traits::size_type,
                             typename _Alty_traits::difference_type, typename _Alty_traits::pointer,
                             typename _Alty_traits::const_pointer, _Elem&, const _Elem&>>>;
#endif

to this:

namespace detail
{
// different with resize, not all of fill new memory with '\0'
template <class _Elem, class _Traits = std::char_traits<_Elem>,
          class _Alloc = std::allocator<_Elem>>
class intrusive_string : public std::basic_string<_Elem, _Traits, _Alloc>
{
public:
#if _MSC_VER >= 1935 // VS2022 v17.8.0+
  using _Alty        = std::_Rebind_alloc_t<_Alloc, _Elem>;
  using _Alty_traits = std::allocator_traits<_Alty>;

  using _Scary_val = std::_String_val<
      std::conditional_t<std::_Is_simple_alloc_v<_Alty>, std::_Simple_types<_Elem>,
                         std::_String_iter_types<
                             _Elem, typename _Alty_traits::size_type,
                             typename _Alty_traits::difference_type, typename _Alty_traits::pointer,
                             typename _Alty_traits::const_pointer>>>;
#elif _MSC_VER >= 1920 // VS2019+
  using _Alty        = std::_Rebind_alloc_t<_Alloc, _Elem>;
  using _Alty_traits = std::allocator_traits<_Alty>;

  using _Scary_val = std::_String_val<
      std::conditional_t<std::_Is_simple_alloc_v<_Alty>, std::_Simple_types<_Elem>,
                         std::_String_iter_types<
                             _Elem, typename _Alty_traits::size_type,
                             typename _Alty_traits::difference_type, typename _Alty_traits::pointer,
                             typename _Alty_traits::const_pointer, _Elem&, const _Elem&>>>;
#endif

[aismann]

Edit: I get the same error with VS 17.8.0 and fix works

[rh101]

Thanks for confirming!

[halx99]

@rh101 could you create a PR?

[rh101]

@rh101 could you create a PR

Create a PR against this project or is there another repository I should log it against for the thirdparty ntcvt?

[halx99]

you can create PR for this repo only