search

axyz / middleman-zurb-foundation

Middleman Skeleton For Zurb Foundation
92 stars 22 forks source link

Remapped jquery | updated all.js #6

Closed ppowalowski closed 10 years ago

ppowalowski commented 10 years ago

This maps the jquery require to the bower version belonging to foundation inside the middleman template.

axyz commented 10 years ago

jquery/jquery tells sprockets to search for bower_components/jquery/jquery.js

I don't see any dist dir inside jquery on bower_components (but I've not updated it, have they created one?)

Maybe you are suggesting to use the foundation version of jquery, but it is in the directory bower_components/foundation/js/vendor/jquery.js so the correct require should be //= require foundation/js/vendor/jquery and not //= require jquery/dist/jquery

please let me know if i have misunderstood your commit.

Thanks for contributing

ppowalowski commented 10 years ago

//= require jquery/dist/jquery works for me. Seems jquery somehow is built into jquery/dist while being fetched by bower. (confirmed with bower install jquery). Right, I think including the most present version straight form jquery repo resulting from the dependency in foundation component should be the way to go instead of that one being served inside vendor by foundation. So the proposed change is correct.

Cheers there is no jquery.js in bower_components/jquery anymore.

axyz commented 10 years ago

you were right: they've changed the directory structure. Merged!

Thanks.