search

ay-lab / fithic

Fit-Hi-C is a tool for assigning statistical confidence estimates to chromosomal contact maps produced by genome-wide genome architecture assays such as Hi-C.
MIT License
79 stars 16 forks source link

Standard Error is always 0 #28

Closed joreynajr closed 4 years ago

joreynajr commented 4 years ago

Between lines 887 and 897 in fithic/fithic/fithic.py there is some commenting out of some standard error calculation?

aryakaul commented 4 years ago

Hey Joaquin,

Std error calculation previously used would have been too slow given how FitHiC2 is set up. We made the decision to nix it, but kept the column for consistent formatting. Don't believe there's currently any plans to include it

joreynajr commented 4 years ago

Thanks Arya, I ended up not needing it but I appreciate the quick response. Just for future reference, if I did uncomment those lines would FitHiC2 then calculate std error?

aryakaul commented 4 years ago

Hey Joaquin, No underlying datastructures have changed which the old stderror calculation relied on.

joreynajr commented 4 years ago

Thanks Arya, I'll go ahead and close this.