ay-lab / mustache

Multi-scale Detection of Chromatin Loops from Hi-C and Micro-C Maps using Scale-Space Representation
MIT License
64 stars 11 forks source link

no module named 'straw' #40

Closed ccmeth closed 2 years ago

ccmeth commented 2 years ago

Hi,

Recently I decided to use this package to identify chromatin loops, and when I run this command ( python3 ./mustache/mustache/mustache.py -f ./mustache/data/chr21_5kb.RAWobserved -b ./mustache/data/chr21_5kb.KRnorm -ch 21 -r 5kb -o chr21_out5.tsv -pt 0.1 -st 0.8 ), an error (no module named straw) appeared. Then I installed the hic-straw through pip, however, this error was not solved.

Could you please tell me how to solve this issue?

mblanche commented 2 years ago

Hi guys, same problem here. I have installed both straw-hic from the Aiden lab and mustache-hic from you using pip3 in a docker image I'm building and I'm getting the same error:

$ docker run -it dovetailg/mustache mustache -h
Traceback (most recent call last):
  File "/usr/local/bin/mustache", line 5, in <module>
    from mustache.mustache import main
  File "/usr/local/lib/python3.8/dist-packages/mustache/mustache.py", line 14, in <module>
    import straw
ModuleNotFoundError: No module named 'straw'

Any help here? I think it's a problem from the straw module itself...

mblanche commented 2 years ago

Hey guys, line 14 of https://github.com/ay-lab/mustache/blob/master/mustache/mustache.py

from pypi hic-straw, the import should be import hicstraw

Could you push a quick hotfix?

mblanche commented 2 years ago

Or maybe you could review and accept the pull request from @sa501428 from the Aiden lab? https://github.com/ay-lab/mustache/pulls/sa501428

ay-lab commented 2 years ago

I thought we had accepted that pull request but seems like we didn't. I accepted it now. Please let us know if that works. Abbas will review it further to make sure everything works fine.

mblanche commented 2 years ago

Great! Did you updated pipy as well?

ay-lab commented 2 years ago

Yes. I believe everyone needs to update the hic-straw now: "pip install hic-straw==1.3.0"

mblanche commented 2 years ago

Sorry, my question was whether your were planning on updating mustach-hic release to the latest version on pypi. Makes handling docker build easier!

Sent from my iPad

-- Marco

On Apr 29, 2022, at 12:24 PM, ay-lab @.***> wrote:

 Yes. I believe everyone needs to update the hic-straw now: "pip install hic-straw==1.3.0"

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

ay-lab commented 2 years ago

yes, mustache pypi is updated to 1.2.5.

mblanche commented 2 years ago

Great! Will update the docker image, restart the pipeline and let you know how it goes.

Best,

Marco

Sent from my iPhone

On Apr 29, 2022, at 1:26 PM, ay-lab @.***> wrote:

 yes, mustache pypi is updated to 1.2.5.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

ccmeth commented 2 years ago

Hey guys, line 14 of https://github.com/ay-lab/mustache/blob/master/mustache/mustache.py

from pypi hic-straw, the import should be import hicstraw

Could you push a quick hotfix?

Thanks for your suggestion! Based on this, the issue has been solved.