search

ay-lab / mustache

Multi-scale Detection of Chromatin Loops from Hi-C and Micro-C Maps using Scale-Space Representation
MIT License
64 stars 11 forks source link

issue using diff_mustache with .mcools #45

Open Elphege-Nora opened 2 years ago

Elphege-Nora commented 2 years ago

Thank you for a great software.

I am unable to run diff_mustache.py with .mcool files as input (no problem running mustache.py on the same files)

python3 ./mustache/mustache/diff_mustache.py -f1 file1.mcool -f2 file2.mcool -pt 0.1 -pt2 0.1 -o output -r 10000 -st 0.8

gives me 

Reading contact map...
Traceback (most recent call last):
  File "./mustache/diff_mustache.py", line 910, in <module>
    main()
  File "./mustache/diff_mustache.py", line 838, in main
    o = regulator(f1, f2, args.norm_method, CHRM_SIZE, args.outdir,
  File "./mustache/diff_mustache.py", line 607, in regulator
    x1, y1, v1 = read_mcooler(f1, distance_in_bp, chromosome,chromosome2, res, norm_method)
NameError: name 'read_mcooler' is not defined

do I need to declare the .mcool files differently? Many thanks in advance!

ay-lab commented 2 years ago

Thanks for pointing out the issue. Should be fixed now.