search

aya-rs / aya

Aya is an eBPF library for the Rust programming language, built with a focus on developer experience and operability.
https://aya-rs.dev/book/
Apache License 2.0
3.25k stars 291 forks source link

Add a 6.10 linux kernel to the virtualized testing in CI #1013

Closed astoycos closed 3 months ago

astoycos commented 3 months ago

Ensure we run our integration tests against linux-image-6.10.4-cloud-amd64-unsigned_6.10.4-1_amd64.deb

Bump xdpilone version to fix bug on latest kernel.

netlify[bot] commented 3 months ago

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
Latest commit 25beb14ff06fb94fb112433ccf12a6db4f2bf89e
Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/66c506cb27e29a0008797cda
Deploy Preview https://deploy-preview-1013--aya-rs-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

astoycos commented 3 months ago

Blocked on https://github.com/HeroicKatora/xdpilone/issues/3

astoycos commented 3 months ago

@Tuetuopay It looks like you added the xdpilone dep wdyt about this failure ^^ I'm seeing it locally on Fedora 40 as well

tamird commented 3 months ago

We shouldn't need to bump the host kernel to test on a particular kernel. That's the whole point of the work done in https://github.com/aya-rs/aya/pull/733. Can we just add another kernel to the integration tests?

Tuetuopay commented 3 months ago

Seems to be fixed upstream. I’ll take a look tomorrow wrt backwards compatibility, but given the fix it should be good. The integration tests should only need a version bump.

astoycos commented 3 months ago

We shouldn't need to bump the host kernel to test on a particular kernel. That's the whole point of the work done in #733. Can we just add another kernel to the integration tests?

Hrm @tamird but for the the runner.os == 'Linux' case we still run the integration tests in "local mode". I do agree that for the debian kernels we download I can just bump the version there.

tamird commented 3 months ago

We shouldn't need to bump the host kernel to test on a particular kernel. That's the whole point of the work done in #733. Can we just add another kernel to the integration tests?

Hrm @tamird but for the the runner.os == 'Linux' case we still run the integration tests in "local mode". I do agree that for the debian kernels we download I can just bump the version there.

Yes, and? Unsupported tests should be skipped.