search

ayurmedia / atom-sync-cygwin

Atom package to sync files bidirectionally between remote host and local over ssh+rsync optimized for Windows with cygwin
https://atom.io/packages/atom-sync-cygwin
MIT License
5 stars 5 forks source link

Add support for rsync `--exclude-from` #13

Closed cr1901 closed 6 years ago

cr1901 commented 6 years ago

This is uncommon, but I ran into a use case where I needed to exclude a number of generated files all over a source tree when xferring to a remote system. It's possible that using exclude for each file could exceed the command line length for rsync in extreme cases, so I elected to add support for --exclude-from, using the config file option excludeFrom.

I tested this and it works fine, even in combination with exclude! However, the main limitation is that the path must be absolute- from the scope where rsync is invoked in this package, I'm unsure how to make the exclude file relative to the project root (nor whether it's even desirable).

I understand you no longer use Atom, but I am open to feedback and changes nonetheless :).

ayurmedia commented 6 years ago

its published v0.9.21

cr1901 commented 6 years ago

@ayurmedia I just realized this, but I think you forgot to update packages.json with the new version number? Atom claims "all my packages are up to date"; I currently have your package installed through apm link. Atom claims the package version is v0.9.19, but my changes are visible (msys: false) in the currently running package.

ayurmedia commented 6 years ago

i just used github to publish it, i have to check if there needs to be an extra tag to bump the version-number.

ayurmedia commented 6 years ago

i updated package.js manually to 0.9.22, and published a new release. hopefully it works now. https://github.com/ayurmedia/atom-sync-cygwin/releases/tag/v0.9.22

cr1901 commented 6 years ago

Atom still thinks all my packages are up to date. I'll give it a day or two to refresh and report back if I can/can't update. Apparently, you have to do apm publish or something?

ayurmedia commented 6 years ago

that's a pity, seems i have to manually checkout the repo and do the apm publish. i thought its enough to do it in github. and make a release. i will do it tomorrow when i find time.

https://atom.io/packages/atom-sync-cygwin still shows 0.9.19, so it didn't pull the release from github. seems atom.io needs the "apm publish" would be nice to do it directly on github or other interface. and not on the commandline.

ayurmedia commented 6 years ago

i did the checkout + apm publish minor. should be now 0.10.0 https://atom.io/packages/atom-sync-cygwin shows 0.10.0 now.

seems no way around command line here.

apm publish automatically changes the package.js. its more like a deploy tool.

but you gave the hint in the right direction.

cr1901 commented 6 years ago

@ayurmedia The package has been updated according to Atom. Thanks for your help and continuing to maintain the plugin :)!