This bug was introduced when we upgraded numpy 1.13 -> 1.15 in 26ddea7240015419f7638028f681458b828a866c
I went through the numpy release notes but don't see the entry that would have caused this error.
Testing Instructions
percentile_* indicator queries should now not crash when provided with a custom percentile HTTP param. The default was unaffected because we set it as an integer.
An example query that should now pass, when before it failed:
Optionally, you can verify that the numpy upgrade was the issue by:
checking out develop
setting numpy==1.13.3 in your django/requirements.txt file
run docker-compose build --no-cache django within the VM to rebuild the container
start the dev server again
Once you've done that, make the same request noted above. It should succeed.
Notes
I ran queries for most of the other classes of indicators that use extra params and didn't run into any other issues. So hopefully there aren't any other lurking issues from the numpy upgrade.
Checklist
[x] Does the python linter pass?
[x] Do tests pass?
[ ] Has the API documentation been updated, or does this PR not require it?
Overview
This bug was introduced when we upgraded numpy 1.13 -> 1.15 in 26ddea7240015419f7638028f681458b828a866c
I went through the numpy release notes but don't see the entry that would have caused this error.
Testing Instructions
percentile_*indicator queries should now not crash when provided with a custompercentileHTTP param. The default was unaffected because we set it as an integer.An example query that should now pass, when before it failed:
Optionally, you can verify that the
numpyupgrade was the issue by:numpy==1.13.3in your django/requirements.txt filedocker-compose build --no-cache djangowithin the VM to rebuild the containerstart the dev server again
Once you've done that, make the same request noted above. It should succeed.
Notes
I ran queries for most of the other classes of indicators that use extra params and didn't run into any other issues. So hopefully there aren't any other lurking issues from the
numpyupgrade.Checklist
Has the API documentation been updated, or does this PR not require it?See|Connects #XXX